haopengzhan/hireme
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: migrate all log statements to structured logger calls for improved observability

Browse Source
This commit is contained in:
haopengzhan
2026-08-15 00:15:27 -07:00
parent 86a092ecd3
commit 150e3dfbd5
6 changed files with 43 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/db/db.go
+2 -2
View File
@@ -3,8 +3,8 @@ package db
import (
"database/sql"
"fmt"
"log"
"github.com/hireme/hireme/internal/logger"
_ "github.com/mattn/go-sqlite3"
)
@@ -31,7 +31,7 @@ func InitDB(dbPath string) (*DB, error) {
return nil, fmt.Errorf("failed to run sqlite migrations: %w", err)
}
log.Printf("[DB] SQLite database initialized successfully at %s", dbPath)
logger.Log.Infow("SQLite database initialized successfully", "component", "DB", "dbPath", dbPath)
return database, nil
}
internal/db/tasks.go
+3 -2
View File
@@ -4,7 +4,8 @@ import (
"database/sql"
"encoding/json"
"fmt"
"log"
"github.com/hireme/hireme/internal/logger"
)
// QueueStats holds task queue counters
@@ -96,7 +97,7 @@ func (db *DB) FailTask(id int64, errStr string) error {
var retryCount int
err := db.QueryRow(`SELECT retry_count FROM tasks WHERE id = ?`, id).Scan(&retryCount)
if err != nil {
log.Printf("[DB] FailTask: failed to get retry_count for task %d: %v", id, err)
logger.Log.Errorw("FailTask: failed to get retry_count", "component", "DB", "task_id", id, "error", err)
return err
}
internal/ui/handlers.go
+18 -6
View File
@@ -94,7 +94,7 @@ func (s *Server) handleIndex(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "text/html; charset=utf-8")
if err := RenderPage(w, data); err != nil {
logger.Log.Errorf("[UI] RenderPage error: %v", err)
logger.Log.Errorw("RenderPage error", "component", "UI", "error", err)
}
}
@@ -124,6 +124,8 @@ func (s *Server) handleCreateTarget(w http.ResponseWriter, r *http.Request) {
return
}
logger.Log.Infow("Triggered /targets (Create)", "component", "API", "name", name, "platform", platform)
_, err := s.db.CreateTarget(name, targetURL, platform)
if err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
@@ -141,6 +143,8 @@ func (s *Server) handleToggleTarget(w http.ResponseWriter, r *http.Request) {
return
}
logger.Log.Infow("Triggered /targets/{id}/toggle", "component", "API", "target_id", id)
if err := s.db.ToggleTargetStatus(id); err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
return
@@ -186,6 +190,8 @@ func (s *Server) handleAnalyzeJob(w http.ResponseWriter, r *http.Request) {
return
}
logger.Log.Infow("Triggered /jobs/{id}/analyze", "component", "API", "job_id", id)
// Enqueue analyze task instead of synchronous processing
payload := worker.AnalyzePayload{RawJobID: int64(id)}
err = s.db.EnqueueTask("ANALYZE", payload)
@@ -206,6 +212,8 @@ func (s *Server) handleOptOut(w http.ResponseWriter, r *http.Request) {
return
}
logger.Log.Infow("Triggered /jobs/{id}/opt-out", "component", "API", "job_id", id)
_, err = s.db.CreateOrUpdateApplication(id, "OPTED_OUT", "")
if err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
@@ -249,6 +257,8 @@ func (s *Server) handleCreateApplication(w http.ResponseWriter, r *http.Request)
return
}
logger.Log.Infow("Triggered /applications (Create)", "component", "API", "raw_job_id", rawJobID, "status", status)
_, err = s.db.CreateOrUpdateApplication(rawJobID, status, "")
if err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
@@ -278,6 +288,8 @@ func (s *Server) handleUpdateAppStatus(w http.ResponseWriter, r *http.Request) {
return
}
logger.Log.Infow("Triggered /applications/{id}/status (Update)", "component", "API", "app_id", appID, "new_status", newStatus)
// Fetch rawJobID for appID
apps, err := s.db.GetApplications()
if err != nil {
@@ -310,7 +322,7 @@ func (s *Server) handleUpdateAppStatus(w http.ResponseWriter, r *http.Request) {
}
func (s *Server) handleDiscoverTasks(w http.ResponseWriter, r *http.Request) {
logger.Log.Info("[API] Triggered /api/tasks/discover")
logger.Log.Infow("Triggered /api/tasks/discover", "component", "API")
targets, err := s.db.GetAllTargets()
if err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
@@ -337,7 +349,7 @@ func (s *Server) handleDiscoverTasks(w http.ResponseWriter, r *http.Request) {
}
func (s *Server) handleCleanTasks(w http.ResponseWriter, r *http.Request) {
logger.Log.Info("[API] Triggered /api/tasks/clean")
logger.Log.Infow("Triggered /api/tasks/clean", "component", "API")
err := s.db.ClearTaskQueue()
if err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
@@ -348,9 +360,9 @@ func (s *Server) handleCleanTasks(w http.ResponseWriter, r *http.Request) {
}
func (s *Server) handleReprocessJobs(w http.ResponseWriter, r *http.Request) {
logger.Log.Info("[API] Triggered /api/tasks/reprocess")
logger.Log.Infow("Triggered /api/tasks/reprocess", "component", "API")
if err := s.db.ReprocessAllJobs(); err != nil {
logger.Log.Errorf("[API] Failed to reprocess jobs: %v", err)
logger.Log.Errorw("Failed to reprocess jobs", "component", "API", "error", err)
http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
@@ -359,7 +371,7 @@ func (s *Server) handleReprocessJobs(w http.ResponseWriter, r *http.Request) {
}
func (s *Server) handleToggleTasks(w http.ResponseWriter, r *http.Request) {
logger.Log.Info("[API] Triggered /api/tasks/toggle")
logger.Log.Infow("Triggered /api/tasks/toggle", "component", "API")
isRunning := s.pool.Toggle()
status := "paused"
if isRunning {
internal/worker/pool.go
+8 -8
View File
@@ -68,7 +68,7 @@ func (p *WorkerPool) Start() {
p.wg.Add(1)
go p.workerLoop(i)
}
logger.Log.Infof("[WorkerPool] Started %d workers", p.workerCount)
logger.Log.Infow("Started workers", "component", "WorkerPool", "count", p.workerCount)
}
func (p *WorkerPool) Stop() {
@@ -78,22 +78,22 @@ func (p *WorkerPool) Stop() {
p.cancel()
p.isRunning.Store(false)
p.wg.Wait()
logger.Log.Infof("[WorkerPool] All workers stopped")
logger.Log.Infow("All workers stopped", "component", "WorkerPool")
}
func (p *WorkerPool) workerLoop(workerID int) {
defer p.wg.Done()
logger.Log.Debugf("[Worker %d] Starting loop", workerID)
logger.Log.Debugw("Starting loop", "component", "Worker", "worker_id", workerID)
for {
select {
case <-p.ctx.Done():
logger.Log.Debugf("[Worker %d] Context cancelled, exiting", workerID)
logger.Log.Debugw("Context cancelled, exiting", "component", "Worker", "worker_id", workerID)
return
default:
task, err := p.db.ClaimNextTask()
if err != nil {
logger.Log.Errorf("[Worker %d] Error claiming task: %v", workerID, err)
logger.Log.Errorw("Error claiming task", "component", "Worker", "worker_id", workerID, "error", err)
time.Sleep(1 * time.Second)
continue
}
@@ -104,7 +104,7 @@ func (p *WorkerPool) workerLoop(workerID int) {
continue
}
logger.Log.Debugf("[Worker %d] Picked up task %d (%s)", workerID, task.ID, task.TaskType)
logger.Log.Debugw("Picked up task", "component", "Worker", "worker_id", workerID, "task_id", task.ID, "task_type", task.TaskType)
// Process task based on type
var processErr error
@@ -122,10 +122,10 @@ func (p *WorkerPool) workerLoop(workerID int) {
}
if processErr != nil {
logger.Log.Errorf("[Worker %d] Task %d FAILED: %v", workerID, task.ID, processErr)
logger.Log.Errorw("Task FAILED", "component", "Worker", "worker_id", workerID, "task_id", task.ID, "error", processErr)
_ = p.db.FailTask(task.ID, processErr.Error())
} else {
logger.Log.Debugf("[Worker %d] Task %d COMPLETED", workerID, task.ID)
logger.Log.Debugw("Task COMPLETED", "component", "Worker", "worker_id", workerID, "task_id", task.ID)
_ = p.db.CompleteTask(task.ID)
}
}