From ab237c317ba3dac39bf578eb4c1cc7e86d021c7c Mon Sep 17 00:00:00 2001 From: Eric McCormick Date: Fri, 1 Dec 2017 09:40:22 -0600 Subject: [PATCH 1/3] adds gem 'wdm', '>= 0.1.0' if Gem.win_platform? to Gemfile this is the recommended for windows from https://jekyllrb.com/docs/windows/ --- Gemfile | 3 ++- Gemfile.lock | 8 +++++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/Gemfile b/Gemfile index a693021..7dcf653 100644 --- a/Gemfile +++ b/Gemfile @@ -1,3 +1,4 @@ source "https://rubygems.org" -gem 'github-pages' \ No newline at end of file +gem 'github-pages' +gem 'wdm', '>= 0.1.0' if Gem.win_platform? \ No newline at end of file diff --git a/Gemfile.lock b/Gemfile.lock index 4b9ea64..361b5f6 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -19,6 +19,7 @@ GEM faraday (0.12.2) multipart-post (>= 1.2, < 3) ffi (1.9.18) + ffi (1.9.18-x64-mingw32) forwardable-extended (2.6.0) gemoji (3.0.0) github-pages (150) @@ -167,6 +168,8 @@ GEM net-dns (0.8.0) nokogiri (1.8.0) mini_portile2 (~> 2.2.0) + nokogiri (1.8.0-x64-mingw32) + mini_portile2 (~> 2.2.0) octokit (4.7.0) sawyer (~> 0.8.0, >= 0.5.3) pathutil (0.14.0) @@ -193,12 +196,15 @@ GEM tzinfo (1.2.3) thread_safe (~> 0.1) unicode-display_width (1.3.0) + wdm (0.1.1) PLATFORMS ruby + x64-mingw32 DEPENDENCIES github-pages + wdm (>= 0.1.0) BUNDLED WITH - 1.14.3 + 1.16.0 From 38959e930f1cb3f03199e6ab9a9bff59510d572b Mon Sep 17 00:00:00 2001 From: Eric McCormick Date: Fri, 1 Dec 2017 09:45:47 -0600 Subject: [PATCH 2/3] corrects spacing issue with svg icon height refs: #13 --- _sass/_resume.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/_sass/_resume.scss b/_sass/_resume.scss index ef2bfbb..14b1add 100644 --- a/_sass/_resume.scss +++ b/_sass/_resume.scss @@ -101,6 +101,10 @@ @include transition(all .2s ease); } } + + .icon { + height: 28px; + } } .contact-button { From 9a419dd822a5bddf7863956995f463cb5fd13dac Mon Sep 17 00:00:00 2001 From: Eric McCormick Date: Fri, 1 Dec 2017 10:32:17 -0600 Subject: [PATCH 3/3] adds comment re: regeneration gem on win re: https://github.com/jglovier/resume-template/pull/48#discussion_r154385962 --- Gemfile | 1 + 1 file changed, 1 insertion(+) diff --git a/Gemfile b/Gemfile index 7dcf653..c8def87 100644 --- a/Gemfile +++ b/Gemfile @@ -1,4 +1,5 @@ source "https://rubygems.org" gem 'github-pages' +# this gem provides regeneration support improvements on Windows gem 'wdm', '>= 0.1.0' if Gem.win_platform? \ No newline at end of file